Skip to content

Conversation

@ablaom
Copy link
Member

@ablaom ablaom commented Feb 2, 2026

This PR extends the JSON compatibility requirements, and fixes the following breakage: In the early version of JSON, the function JSON.parse would return a Dict{String,Any} but now it returns a custom type JSON.Object{String,Any}. While JSON.Object is an AbstractDict, many type annotations for methods in MLFlowClient.jl expect a Dict. I have mitigated this problem by loosening these type annotations to AbstractDict. (The only reason for having annotations at all appears to be as a guard against improper arguments, but for the internal functions this seems unnecessary. However, not being too familiar with the code base I have kept the annotations.)

I have also added a warning in the Readme against using MLflow > 3.2.0, as I ran into an issue, reported at #76.

@ablaom ablaom marked this pull request as draft February 2, 2026 21:10
@ablaom ablaom closed this Feb 2, 2026
@ablaom ablaom reopened this Feb 2, 2026
@ablaom ablaom closed this Feb 3, 2026
@ablaom ablaom reopened this Feb 3, 2026
@ablaom ablaom marked this pull request as ready for review February 4, 2026 00:29
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.09%. Comparing base (0a92b04) to head (d5c42f3).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   90.39%   90.09%   -0.30%     
==========================================
  Files          21       20       -1     
  Lines         406      414       +8     
==========================================
+ Hits          367      373       +6     
- Misses         39       41       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ablaom
Copy link
Member Author

ablaom commented Feb 4, 2026

I have been unable to make contact with a regular maintainer and so will merge this in 48 hours, as this is needed downstream and the changes seem to me fairly innocuous. Any review will be greatly appreciated, but let me know ASAP if you want to make one.

cc @pebeto @deyandyankov

@ablaom ablaom closed this Feb 4, 2026
@ablaom ablaom reopened this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants