install diff-filter-buildkite-plugin to only build when relevant files changed#400
install diff-filter-buildkite-plugin to only build when relevant files changed#400fatteneder wants to merge 20 commits intoJuliaCI:mainfrom
Conversation
e0bd514 to
36db0ee
Compare
|
I believe NEWS.md and HISTORY.md are in the docs, so I think it needs at least the docs to be built for those? |
9b18b56 to
df7d25c
Compare
617363c to
014c2cc
Compare
e12afd6 to
9ccf4d5
Compare
|
I think I managed to implement a mechanism to override the filter using Github labels and the github-pr-labels-buildkite-plugin. I think the basic functionality is now there.
|
giordano
left a comment
There was a problem hiding this comment.
I don't know if this is what the ignore-list is for (it's quite short, so can't tell it's what I'm thinking of), but for changes which involve only any of
.devcontainer.github(JuliaLang/julia#56468 shouldn't have run buildkite CI).clang-format.clangd.git-blame-ignore-revs.gitignore.mailmapCITATION.bibCITATION.cffjulia.spdx.jsontypos.toml
shouldn't run any CI here at all. After this, for docs-related changes I think we need probably to build for all platforms but not run any test suites apart from the doctests? Not sure if this is what #400 (comment) was suggesting.
|
|
||
| common: | ||
| - diff-filter-build_plugin: &diff-filter-build | ||
| https://github.com/fatteneder/diff-filter-buildkite-plugin#main: |
There was a problem hiding this comment.
I guess this should be moved to this organisation before merge.
This can likely be simplified to: apply the filter iff the repo is JuliaLang/julia and it is a PR. |
Following #400 (comment) we now always build |
Ok, I did not yet test how the plugin behaves once a PR is merged. About |
fc89bd0 to
8dbfb8d
Compare
|
I have not permissions on this repo/in this org. Can someone please add the |
|
Closing and reopening a PR doesn't retrigger build kite unfortunately. I asked Bill kite Support about that a while back, and they told me that was is the intended behavior. you'll need to go to the build kite build and click the rebuild button. |
3f540fe to
7627e90
Compare
|
Bump. I was wondering if it would be possible to add another layer/step to check if other signed/unsigned CI jobs are to be started. |
# Conflicts: # pipelines/main/launch_upload_jobs.yml
This reverts commit f300c57.
7627e90 to
4942000
Compare
|
@inkydragon I don't understand your request. Could you expand a bit? |
Fixes #243
This adds a filter that skips (most of the) build and test steps in the CI pipeline if a PR only changed files that are irrelevant for Julia's functionality.
In particular, changes to any of these files won't trigger a build (glob patterns as seen from the root of the Julia repo):
"*.md"".*""julia.spdx.json""CITATION.*""typos.toml"Note that we always build for
x86_64-linux-gnuin order to generate the docs.The filter can be disabled on a PR basis by adding a label with the name
ci-force-buildto it.The addition of more fine grained filters is left for future PRs.