Fix deprecation of DisjointSets(xs...) to avoid warning on package load#951
Merged
oxinabox merged 1 commit intoJuliaCollections:masterfrom Aug 26, 2025
Merged
Conversation
odow
commented
Aug 25, 2025
oxinabox
approved these changes
Aug 25, 2025
Member
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
Thank you.
Looks good.
Can you bump the version number?
odow
commented
Aug 25, 2025
Contributor
Author
|
I bumped but then reverted. There's actually a few commits on |
odow
force-pushed
the
od/fix-deprecation
branch
from
46ec63b to
4595212
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecation broke JuMP and a bunch of related packages that test with
--depwarn=error(to avoid using deprecated bindings): jump-dev/JuMP.jl#4058One downside to this PR is that it introduces a new (deprecated)
DisjointSet(xs...)method.There is already a test that
DisjointSets(xs...)is equivalent toDisjointSet(xs...)and thenDisjointSet(xs):DataStructures.jl/test/test_disjoint_set.jl
Line 168 in bf5146d