WIP: External package for matrix equations#443
Open
olof3 wants to merge 2 commits intoJuliaControl:masterfrom
Open
WIP: External package for matrix equations#443olof3 wants to merge 2 commits intoJuliaControl:masterfrom
olof3 wants to merge 2 commits intoJuliaControl:masterfrom
Conversation
olof3
force-pushed
the
external_matrixeq_pkg
branch
from
1b44cd2 to
6bf8f92
Compare
Member
|
Any updated thoughts on this? This is a nonbreaking change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes to an external package for matrix equations that I've been trying to put together here
https://github.com/olof3/ControlMatrixEquations.jl. See #303 for some benchmarks of the linear solvers and some thoughts on why that package seems like a better way forward (at least for the short term) than going forMatrixEquations. Some things work better than inMatrixEquations, other things work less well (for example informing about numerical problems).So would be great with some people using that package and finding problems (or even contributing). Hopefully some kind of joint effort with
MatrixEquatonscould be made. Regardless of what we decide on I think it would be good if the package became a part of the JuliaControl organization.Some issues that gets fixed by this:
With the better performance of
lyapdit is possible to compute norms of systems with > 150 states (fixes #300).Problems with Ricatti equations that gets fixed: #281, #297, #440