Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 69.74% 69.61% -0.13%
==========================================
Files 12 12
Lines 1702 1774 +72
==========================================
+ Hits 1187 1235 +48
- Misses 515 539 +24 ☔ View full report in Codecov by Sentry. |
Collaborator
|
more importantly doc strings and tests 😄 . But, I would like to have the opinion of @meggart on this? |
meggart
reviewed
Oct 19, 2023
Member
meggart
left a comment
There was a problem hiding this comment.
Thanks a lot, yes its a good idea to merge the 2. However, it would be good to be consequent and just deprecate savecube and savedataset (see the docs of the @deprecate macro) so that we can entirely remove them in future YAXArray versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#309
Still needs some docs