You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My intuition is that we would want getproperty(x::Tangent{<:Cholesky}, :U) == getproperty(x::Tangent{<:Cholesky}, :L)'. I think that's not satisfied by the PR?
I guess it might also be useful to define getproperty(x::Tangent{<:Cholesky}, :UL) (at least for completeness and to avoid ZeroTangents in that case as well).
Because we don't have access to the Cholesky object's uplo field, we don't know the relationship between factors, U, and L. e.g. if uplo=='L', then a user requesting ΔC.L should be given LowerTriangular(ΔC.factors), and a user requesting ΔC.U should be given LowerTriangular(ΔC.factors)', but the case is completely different if uplo=='U'. Currently this rule will only work when Symbol(C.uplo) == sym. I'm not certain if/how this can be resolved, short of modifying Tangent to include metadata from the primal object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs version bumpVersion needs to be incremented or set to -DEV in Project.toml
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial code for closing #640. I'm open to changing what it checks, but this seems like any easy way to minimize breaking changes for now.