fix: respect array type in wrong-mode pushforward/pullback#620
Draft
fix: respect array type in wrong-mode pushforward/pullback#620
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
===========================================
- Coverage 97.95% 64.44% -33.51%
===========================================
Files 119 114 -5
Lines 6246 6258 +12
===========================================
- Hits 6118 4033 -2085
- Misses 128 2225 +2097
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
The issue at the moment is with GPUArrays because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DI source
pushforward/pullback, givex/yas a first argument to themapover cartesian indices. This allows array types (e.g. static or GPU) to be preserved.