fix: handle constant derivatives with runtime activity for Enzyme#850
Draft
fix: handle constant derivatives with runtime activity for Enzyme#850
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
===========================================
- Coverage 98.12% 79.12% -19.00%
===========================================
Files 134 130 -4
Lines 7988 7972 -16
===========================================
- Hits 7838 6308 -1530
- Misses 150 1664 +1514
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #666
Unfortunately, since it relies on
pointer(y) == pointer(dy), it only works forArrayat the moment. Any clue on how to generalize to arbitrary structs is welcome (keeping in mind thaty === dydoesn't do what we want)cc @wsmoses