Skip to content

Comments

Fix Orthographic inverse#231

Merged
eliascarv merged 1 commit intomainfrom
fix-orthographic
Dec 19, 2024
Merged

Fix Orthographic inverse#231
eliascarv merged 1 commit intomainfrom
fix-orthographic

Conversation

@eliascarv
Copy link
Member

setup:

julia> ShiftedOrthoSpherical = CoordRefSystems.shift(CoordRefSystems.Orthographic{CoordRefSystems.SphericalMode,30.0°,WGS84Latest}, lonₒ=60°);

julia> c1 = LatLon(30, 60)
GeodeticLatLon{WGS84Latest} coordinates
├─ lat: 30.0°
└─ lon: 60.0°

julia> c2 = convert(ShiftedOrthoSpherical, c1)
Orthographic{WGS84Latest} coordinates with lonₒ: 60.0°, xₒ: 0.0 m, yₒ: 0.0 m
├─ x: 0.0 m
└─ y: 0.0 m

main:

julia> convert(LatLon, c2)
GeodeticLatLon{WGS84Latest} coordinates
├─ lat: 29.999999999999996°
└─ lon: 120.0°

PR:

julia> convert(LatLon, c2)
GeodeticLatLon{WGS84Latest} coordinates
├─ lat: 29.999999999999996°
└─ lon: 60.0°

As implemented in Lambert Azimuthal Equal Area, the correct return for lambda in this case is zero, because the shift is applied in a post-process step.

@eliascarv eliascarv requested a review from juliohm December 19, 2024 17:13
@eliascarv eliascarv merged commit 5422bd6 into main Dec 19, 2024
6 checks passed
@eliascarv eliascarv deleted the fix-orthographic branch December 19, 2024 17:16
@juliohm
Copy link
Member

juliohm commented Dec 19, 2024 via email

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (726ecdc) to head (89039da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   94.65%   94.64%   -0.01%     
==========================================
  Files          33       33              
  Lines        1534     1532       -2     
==========================================
- Hits         1452     1450       -2     
  Misses         82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants