add zero dim matmat/matvec-mul tests#646
Draft
tam724 wants to merge 2 commits intoJuliaGPU:masterfrom
Draft
Conversation
Contributor
Author
|
Test failures are expected: |
kshyatt
force-pushed
the
test_zero_dim_matmat_matvec_edgecases
branch
from
44c8bdd to
7dcff50
Compare
Member
|
@tam724 now with the CUDA changes merged, is this ready to go? |
Contributor
Author
|
No, because it adds tests into the testsuite, merging this PR would break the CI for Metal.jl and oneAPI.jl. |
Member
|
Canceled the macOS build for this due to queue pressure and it's not ready anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see JuliaGPU/CUDA.jl#2958.