[CI] Use init_worker_code to reduce testset initialization overhead#739
Open
christiangnrd wants to merge 3 commits intomainfrom
Open
[CI] Use init_worker_code to reduce testset initialization overhead#739christiangnrd wants to merge 3 commits intomainfrom
init_worker_code to reduce testset initialization overhead#739christiangnrd wants to merge 3 commits intomainfrom
Conversation
init_worker_code to reduce testset initialization overhead
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 82.59% 82.63% +0.03%
==========================================
Files 62 62
Lines 2862 2862
==========================================
+ Hits 2364 2365 +1
+ Misses 498 497 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 0b378c4.
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/runtests.jl b/test/runtests.jl
index 87550397..22d281d6 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -98,7 +98,7 @@ end
# workers to run tests on
function test_worker(name, init_worker_code)
if name == "capturing"
- return addworker(; env=["METAL_CAPTURE_ENABLED"=>"1"], init_worker_code)
+ return addworker(; env = ["METAL_CAPTURE_ENABLED" => "1"], init_worker_code)
end
return nothing |
Contributor
There was a problem hiding this comment.
Metal Benchmarks
Details
| Benchmark suite | Current: 9edd35b | Previous: 043dbed | Ratio |
|---|---|---|---|
latency/precompile |
25694587792 ns |
25147544500 ns |
1.02 |
latency/ttfp |
2299697000 ns |
2280876000 ns |
1.01 |
latency/import |
1455671209 ns |
1448341375 ns |
1.01 |
integration/metaldevrt |
850375 ns |
856042 ns |
0.99 |
integration/byval/slices=1 |
1598125 ns |
1561437.5 ns |
1.02 |
integration/byval/slices=3 |
20031187.5 ns |
9985729 ns |
2.01 |
integration/byval/reference |
1571167 ns |
1550625 ns |
1.01 |
integration/byval/slices=2 |
2729458 ns |
2554125.5 ns |
1.07 |
kernel/indexing |
475604.5 ns |
621792 ns |
0.76 |
kernel/indexing_checked |
481875 ns |
630000 ns |
0.76 |
kernel/launch |
12625 ns |
11833 ns |
1.07 |
kernel/rand |
530979 ns |
569041 ns |
0.93 |
array/construct |
6209 ns |
6375 ns |
0.97 |
array/broadcast |
543917 ns |
594416 ns |
0.92 |
array/random/randn/Float32 |
1011375 ns |
1006834 ns |
1.00 |
array/random/randn!/Float32 |
710667 ns |
752083 ns |
0.94 |
array/random/rand!/Int64 |
535771 ns |
546541 ns |
0.98 |
array/random/rand!/Float32 |
534667 ns |
577979.5 ns |
0.93 |
array/random/rand/Int64 |
910083 ns |
773208.5 ns |
1.18 |
array/random/rand/Float32 |
819375 ns |
589791.5 ns |
1.39 |
array/accumulate/Int64/1d |
1285666 ns |
1262458 ns |
1.02 |
array/accumulate/Int64/dims=1 |
1860583.5 ns |
1837334 ns |
1.01 |
array/accumulate/Int64/dims=2 |
2250979.5 ns |
2166645.5 ns |
1.04 |
array/accumulate/Int64/dims=1L |
12110333 ns |
11676999.5 ns |
1.04 |
array/accumulate/Int64/dims=2L |
9910750 ns |
9763146 ns |
1.02 |
array/accumulate/Float32/1d |
1065250 ns |
1112833 ns |
0.96 |
array/accumulate/Float32/dims=1 |
1602708 ns |
1560562.5 ns |
1.03 |
array/accumulate/Float32/dims=2 |
2028750 ns |
1866625 ns |
1.09 |
array/accumulate/Float32/dims=1L |
10340833 ns |
9806292 ns |
1.05 |
array/accumulate/Float32/dims=2L |
7504125 ns |
7257291 ns |
1.03 |
array/reductions/reduce/Int64/1d |
1306042 ns |
1358250 ns |
0.96 |
array/reductions/reduce/Int64/dims=1 |
1130688 ns |
1089125 ns |
1.04 |
array/reductions/reduce/Int64/dims=2 |
1157500 ns |
1130958 ns |
1.02 |
array/reductions/reduce/Int64/dims=1L |
2054041 ns |
2002353.5 ns |
1.03 |
array/reductions/reduce/Int64/dims=2L |
4031895.5 ns |
4220375 ns |
0.96 |
array/reductions/reduce/Float32/1d |
754958 ns |
1028042 ns |
0.73 |
array/reductions/reduce/Float32/dims=1 |
809666.5 ns |
831916 ns |
0.97 |
array/reductions/reduce/Float32/dims=2 |
834458 ns |
743167 ns |
1.12 |
array/reductions/reduce/Float32/dims=1L |
1342333 ns |
1311125.5 ns |
1.02 |
array/reductions/reduce/Float32/dims=2L |
1817625 ns |
1800750 ns |
1.01 |
array/reductions/mapreduce/Int64/1d |
1306562.5 ns |
1538667 ns |
0.85 |
array/reductions/mapreduce/Int64/dims=1 |
1117500 ns |
1095375 ns |
1.02 |
array/reductions/mapreduce/Int64/dims=2 |
1165041.5 ns |
1139729 ns |
1.02 |
array/reductions/mapreduce/Int64/dims=1L |
1949125 ns |
2011792 ns |
0.97 |
array/reductions/mapreduce/Int64/dims=2L |
3648458 ns |
3621583.5 ns |
1.01 |
array/reductions/mapreduce/Float32/1d |
771187.5 ns |
1055750 ns |
0.73 |
array/reductions/mapreduce/Float32/dims=1 |
799437.5 ns |
819604 ns |
0.98 |
array/reductions/mapreduce/Float32/dims=2 |
839542 ns |
852417 ns |
0.98 |
array/reductions/mapreduce/Float32/dims=1L |
1346750 ns |
1315208.5 ns |
1.02 |
array/reductions/mapreduce/Float32/dims=2L |
1811146.5 ns |
1793125 ns |
1.01 |
array/private/copyto!/gpu_to_gpu |
526541.5 ns |
642208 ns |
0.82 |
array/private/copyto!/cpu_to_gpu |
719646 ns |
794167 ns |
0.91 |
array/private/copyto!/gpu_to_cpu |
707958.5 ns |
788500 ns |
0.90 |
array/private/iteration/findall/int |
1571666 ns |
1564479 ns |
1.00 |
array/private/iteration/findall/bool |
1456958 ns |
1408791.5 ns |
1.03 |
array/private/iteration/findfirst/int |
2101000 ns |
2072062 ns |
1.01 |
array/private/iteration/findfirst/bool |
2023666 ns |
2036375 ns |
0.99 |
array/private/iteration/scalar |
3034937.5 ns |
4806917 ns |
0.63 |
array/private/iteration/logical |
2662000 ns |
2579104 ns |
1.03 |
array/private/iteration/findmin/1d |
2529917 ns |
2506791 ns |
1.01 |
array/private/iteration/findmin/2d |
1843583 ns |
1788792 ns |
1.03 |
array/private/copy |
819500 ns |
576229 ns |
1.42 |
array/shared/copyto!/gpu_to_gpu |
84083 ns |
83125 ns |
1.01 |
array/shared/copyto!/cpu_to_gpu |
82041 ns |
82250 ns |
1.00 |
array/shared/copyto!/gpu_to_cpu |
82208 ns |
82375 ns |
1.00 |
array/shared/iteration/findall/int |
1566479.5 ns |
1574708 ns |
0.99 |
array/shared/iteration/findall/bool |
1477417 ns |
1415562.5 ns |
1.04 |
array/shared/iteration/findfirst/int |
1707042 ns |
1649917 ns |
1.03 |
array/shared/iteration/findfirst/bool |
1648375 ns |
1643167 ns |
1.00 |
array/shared/iteration/scalar |
199729.5 ns |
207208 ns |
0.96 |
array/shared/iteration/logical |
2277375 ns |
2487270.5 ns |
0.92 |
array/shared/iteration/findmin/1d |
2178812.5 ns |
2121917 ns |
1.03 |
array/shared/iteration/findmin/2d |
1838021 ns |
1791791 ns |
1.03 |
array/shared/copy |
210250 ns |
248833 ns |
0.84 |
array/permutedims/4d |
2483125 ns |
2395833 ns |
1.04 |
array/permutedims/2d |
1201916.5 ns |
1178750 ns |
1.02 |
array/permutedims/3d |
1783417 ns |
1686292 ns |
1.06 |
metal/synchronization/stream |
19042 ns |
19042 ns |
1 |
metal/synchronization/context |
19583 ns |
20042 ns |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.