Open
Conversation
…n of this package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Stheno.jl to follow more modern Julia practices. In particular, this drops support for Zygote.jl in favour of Mooncake.jl. While I anticipate some small performance regressions, doing this means that I can drop all of the rules written with Zygote in mind, in favour of just assuming that Mooncake.jl will work correctly. Probably there are a range of operations in this package whose performance can be substantially improved now that we're not relying on Zygote.jl for gradients, but that can wait for a follow-up PR.