Open
Conversation
asinghvi17
reviewed
Oct 30, 2025
| flipped_poly = GO.apply(GI.PointTrait, $poly) do p | ||
| (GI.y(p), GI.x(p)) | ||
| flipped_poly = GO.apply(GO.PointTrait, $poly) do p | ||
| (GO.y(p), GO.x(p)) |
Member
There was a problem hiding this comment.
Not sure this should be GO and not GI...I can see the argument for consistency though
Member
Author
There was a problem hiding this comment.
Yeah its actually not I just went too far in my search and replace
Member
Author
There was a problem hiding this comment.
But kinda useful I think we should just have these. Theres so much getting users to guess what package has what things
Member
There was a problem hiding this comment.
that should be what Geo is for though. I don't want to advertise GO.x because then people will try to override it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to complete the namespace with e.g.
GeometryOps.Polygonand test these and the rest we already had from GeoInterface