Merged
Conversation
giordano
reviewed
Dec 6, 2025
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Contributor
|
Looks reasonable to me and CI passes |
SimonDanisch
reviewed
Dec 9, 2025
| all_zero_hour = length(hours) == 1 && 0 in hours | ||
| all_zero_minute = length(minutes) == 1 && 0 in minutes | ||
| all_zero_seconds = length(minutes) == 1 && 0 in minutes | ||
| all_zero_milliseconds = length(minutes) == 1 && 0 in minutes |
Member
There was a problem hiding this comment.
Where these unused or whats going on here?
Contributor
Author
There was a problem hiding this comment.
I've reverted the code changes to not distract this PR. This method is rather buggy, will add a separate PR to properly fix the bugs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 79.15% 84.65% +5.50%
==========================================
Files 3 2 -1
Lines 283 189 -94
==========================================
- Hits 224 160 -64
+ Misses 59 29 -30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Can the new version be tagged? 🙂 |
Contributor
Author
Please wait until #49 is fixed. (Problably do this in the afternoon) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shaves of 2 seconds of pre-compilation time (measured locally) by removing the dependency on Grisu.jl.
As Showoff is used in Makie and Plots this has adds up for the overall community.