Parse arr[end] differently from arr[var"end"]

[mlechu]

Fixes a small issue present in both parsers (see discussion at JuliaLang/julia#57269) due to treating begin/end in indexing expressions as normal identifiers.

This would be a breaking change that goes with PR JuliaLang/julia#57368, which makes the same change to the lisp parser, and changes lowering to expect Expr(:end) instead of a symbol.

[Keno]

Needs a version check on the parse syntax, since JuliaSyntax itself is not tied to a Julia version.

[mlechu]

Thanks! Assuming 1.12?

[Keno]

Let's do 1.13 - we can change it later if we decide to backport.

[c42f]

I think the changes to SyntaxNode are good here and we should do them even if it's too breaking to change Expr in Base. JuliaSyntax already contains many such AST differences - some of which are much more significant than changing begin/end. (As an example, consider K"dotcall".)

So if you like we could merge this right away if you make sure the Expr form remains unchanged. We just need:

• Tests added to parsestmt_with_kind_tests in test/parser.jl to assert the correct kind for the begin/end leaf nodes in the tree
• Currently-failing tests fixed
• Reuse K"begin" / K"end" rather than make new kinds. Keeping close to the source strings makes it super easy to remember the right kind.

Later you can make a separate PR if PkgEval deems the Expr changes not to be breaking.

[mlechu]

Thanks for the help!

• Tests added to parsestmt_with_kind_tests in test/parser.jl to assert the correct kind for the begin/end leaf nodes in the tree

Am I correct in thinking I would need to update parsestmt_with_kind_tests to take the version into account? I think not.

Waiting on pkgeval before deciding whether to keep the Expr change.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (30109d4) to head (17be4e3).
Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/expr.jl	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   96.18%   96.08%   -0.10%     
==========================================
  Files          13       13              
  Lines        4032     4113      +81     
==========================================
+ Hits         3878     3952      +74     
- Misses        154      161       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[c42f]

Heya, I've created a branch https://github.com/JuliaLang/JuliaSyntax.jl/tree/pr-for-Base/537 to make this easier to move into Base

To make use of the branch, you can use the following steps:

• Clone JuliaLang/julia
• Add JuliaSyntax as a git remote
• Check out pr-for-Base/537
• Rebase on top of master

For example:

# git clone git@github.com:JuliaLang/julia julia_dir
# cd julia_dir

git remote add JuliaSyntax git@github.com:JuliaLang/JuliaSyntax.jl
git fetch JuliaSyntax
git checkout pr-for-Base/537
git rebase origin/master

Sorry this wasn't dealt with prior to the big move!