Add integration test with FFTW backend#75
Add integration test with FFTW backend#75gaurav-arya wants to merge 1 commit intoJuliaMath:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 83.09% 82.60% -0.49%
==========================================
Files 2 2
Lines 207 207
==========================================
- Hits 172 171 -1
- Misses 35 36 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Unfortunately, there's no version of Is it reasonable to bump the minimum Julia compat to |
|
I think it would be good to add downstream tests of e.g. FFTW but IMO it should be done as in ChainRules, SciML, Turing, StatsFuns, etc. by running the tests of the downstream package in a separate action. The main problem with this PR is that it adds a circular dependency which IMO is very annoying to work with and causes test failures every time you introduce a breaking change (e.g. because the downstream package can't be installed since it is not compatible yet). I'll open a PR with the downstream testing setup of these other packages. |
While thinking about how to test JuliaMath/FFTW.jl#249, I thought it might be nice to just run the test suite here with
FFTW. Integration tests would also be useful for sanity checking that the chain rules, etc. do correctly work withFFTW, so it seems like a good thing to have in general.The PR:
FFTWtestfft. Ideally,testfftwould take the FFT backend as input, but see the note in the file :/ At least it makes clear what the issue is currently (see Multiple FFT backends? #32). Hopefully we can add a backend parameter toplan_fftin a future PR (and let FFTW be the default backend for backwards compat)FFTWandTestPlansgroups for testing