Fix the size one case and provide informative error message in the size zero case.#47
Merged
dannys4 merged 1 commit intoJuliaMath:mainfrom Mar 17, 2025
Merged
Conversation
Closed
Closed
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
size zero case. Currently, the size one case errors and the size zero case hangs. I've also added more tests. They revealed a bug in the pow4 fft which I have also fixed.
Member
Author
|
@dannys4 I found the bug in pow4 kernel and have updated this PR with the fix. |
andreasnoack
commented
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the size one case errors and the size zero case hangs. I've also added more tests. There reveal that there is a bug in the pow4 fft but I will file a separate issue for that.
Closes #48