Skip to content

Make FFTW flags "public" #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giordano merged 6 commits into from
Dec 29, 2025
Merged

Make FFTW flags "public" #329

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08e409c
Make FFTW flags "public"
JeffFessler Dec 28, 2025
41335d8
make all flags public
JeffFessler Dec 28, 2025
3c6c124
Limit public to v11 and beyond
JeffFessler Dec 29, 2025
cbccaa1
Isolate public assertions in public.jl
JeffFessler Dec 29, 2025
b5133b8
Use @static and eval
JeffFessler Dec 29, 2025
32ca781
Merge branch 'master' into jf/public
giordano Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/FFTW.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,19 @@ import AbstractFFTs: Plan, ScaledPlan,

export dct, idct, dct!, idct!, plan_dct, plan_idct, plan_dct!, plan_idct!

# FFTW flags from fft.jl
public MEASURE
Copy link
Member

@giordano giordano Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it wasn't clear, public doesn't work in v1.10.

Copy link
Contributor Author

@JeffFessler JeffFessler Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder. I added a VERSION switch.

Copy link
Contributor Author

@JeffFessler JeffFessler Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having public within an if statement did not work; i.e., this fails with the error "Expected end" in v1.12.3 on MacOS:

if true
    public foo
end

Fortunately, having an include within the if statement appears to work, so I isolated the public assertions to a separate file, public.jl, as a workaround. Suggestions welcome.

Copy link
Member

@devmotion devmotion Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use something like https://github.com/JuliaStats/StatsAPI.jl/blob/ee9906ddd8cab08b454d1f0088c5285ac7bed1fe/src/StatsAPI.jl#L5-L10. Or Compat.jl which provides a macro for this expression, but in StatsAPI it didn't seem worth adding an additional dependency (in particular due to the large number of packages that depend on StatsAPI).

Copy link
Contributor Author

@JeffFessler JeffFessler Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devmotion for that very helpful suggestion. I'm giving it a try now.

public DESTROY_INPUT
public UNALIGNED
public CONSERVE_MEMORY
public EXHAUSTIVE
public PRESERVE_INPUT
public PATIENT
public ESTIMATE
public WISDOM_ONLY
public NO_SIMD


include("providers.jl")

function fftw_init_check()
Expand Down
Loading