datadeps: Support programmable scheduling#678
Merged
Conversation
jpsamaroo
force-pushed
the
jps/datadeps-custom-sched
branch
from
7775027 to
c8c9599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
:roundrobin,:naive, and:ultraschedulers intoRoundRobinScheduler(),NaiveScheduler(), andUltraScheduler(), so that schedulers can be defined using dispatch, and so that additional configurations and internal state can be stored within the scheduler instance. This will be helpful for development generally, but also for when certain algorithms benefit from a more specific scheduling strategy.Note that only
RoundRobinScheduler()is supported at the moment - the other two are experimental and most likely broken.Written partially by Claude