[WIP] Use FunctionWrappers for custom reduction operators#637
Draft
giordano wants to merge 1 commit intoJuliaParallel:masterfrom
Draft
[WIP] Use FunctionWrappers for custom reduction operators#637giordano wants to merge 1 commit intoJuliaParallel:masterfrom
FunctionWrappers for custom reduction operators#637giordano wants to merge 1 commit intoJuliaParallel:masterfrom
Conversation
Member
Author
|
I thought that there was a segfault in the call to Lines 598 to 600 in 4cd7118 GC.@preserve'd.
Edit: "should work fine" was probably a bit optimistic, as the result of the reduction is garbage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt at addressing #404. This is using
FunctionWrappers.jlinstead of@cfunction, as suggested in a recent JuliaHPC call.Note: it doesn't work for me even on x86_64 when using more than 1 rank. Simple reproducer:
Run the script with
The program should die with a segmentation fault (but the generated pointer should be non-null, as far as I can tell)