feat: avoid adding packages that exist in the sysimage#2832
Draft
feat: avoid adding packages that exist in the sysimage#2832
Conversation
Contributor
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="pg/pkg-sysimage-handling")
julia> using Pluto |
Member
|
Don't you want to disable the package manager? Like this but not just for new notebooks? #1631 |
Member
Author
I think I don't, no. The Package Manager is amazing. There used to be some limitations (which I don't completely understand) that disallowed us from adding new packages and/or doing a correct resolve in the context of a sysimage. But that doesn't seem to be the case any more (1.10.2). We just need to stop the Package Manager from going crazy with packages in the sysimage, and let it do what it does best for the rest. I think this PR does that, but I haven't tested out thoroughly yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental. When someone is using a sysimage,
using SysImageModuletriggers aPkg.add. This avoids that. I'm still testing if this is exactly what I have in mind; we probably need to do a special treatment that is similar to stdlibs too.