Disable satisfied-skip-solve on 32-bit linux#268
Open
angusmoore wants to merge 1 commit intoJuliaPy:masterfrom
Open
Disable satisfied-skip-solve on 32-bit linux#268angusmoore wants to merge 1 commit intoJuliaPy:masterfrom
angusmoore wants to merge 1 commit intoJuliaPy:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 1 1
Lines 203 203
=======================================
Hits 173 173
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The default install of Conda on 32 bit linux uses repo.anaconda.com/miniconda; those 32 bit builds are very dated and so do not support the --satisfied-skip-solve flag The latest 32 bit linux build (https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86.sh) is 4.5.12, which pre-dates the introduction of --satisfied-skip-solve, which was introduced in 4.6.0 (https://docs.conda.io/projects/conda/en/latest/release-notes.html\#version-4.6.0). This is a somewhat draconian approach, as someone could have a newer build of Conda on a 32 bit linux system, and this change prevents them from using --satisfied-skip-solve. Even so, I think this change is worthwhile because (a) the current state means a default install of PyCall (which sets this flag) on 32 bit linux fails (b) preventing --satisfied-skip-solve does not change correctness, just performance (c) there are probably not a lot of people hitting this code path.
7e971c7 to
899db5b
Compare
angusmoore
added a commit
to angusmoore/ExcelReaders.jl
that referenced
this pull request
Dec 10, 2025
* Remove support for pre 1.10 (this may not be necessary, but seems reasonable) * Add 1.11 and 1.12 to CI * Bumps macOS runner to 15 as 13 is no longer supported; requests aarch64 Julia * Set fail-fast to false to confirm only 32-bit linux CI is (currently) failing due to JuliaPy/Conda.jl#268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: The default install of Conda on 32 bit linux uses pre-built binaries from repo.anaconda.com/miniconda; the 32 bit linux builds are very dated and do not support the --satisfied-skip-solve flag.
Change: Ignore / disable
satisfied_skip_solveon 32 bit linux, in the same way it is ignored on windows (and add a linux-specific warning if it is set to true, as is the case in windows).Detail:
The latest 32 bit linux build (https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86.sh) is 4.5.12, which pre-dates the introduction of --satisfied-skip-solve, which was introduced in 4.6.0 (https://docs.conda.io/projects/conda/en/latest/release-notes.html\#version-4.6.0).
This is a somewhat draconian approach, as someone could have a newer build of Conda on a 32 bit linux system (installed by some other means than the default Conda installer), and this change prevents them from using --satisfied-skip-solve.
Even so, I think this change is worthwhile because (a) the current state means a default install of PyCall (which sets this flag) on 32 bit linux fails (b) preventing --satisfied-skip-solve does not change correctness, just performance (I believe, I'm not an expert on conda) (c) there are probably not a lot of people hitting this code path (on 32 bit linux, with their own, newer, Conda).
An alternative would be to explicitly check the Conda version and if it is
<4.6.0, ignoresatisfied_skip_solve. However, that seemed far more complex / a lot of extra code for little gain (again, given there isn't much cost to disabling satisfied-skip-solve for a likely small share of workflows)Reference: #245 and github.com/JuliaPy/PyCall.jl/pull/1045