Skip to content

Improve git command error logging to include stdout/stderr #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 2 commits into from
Jan 5, 2026
Merged

Improve git command error logging to include stdout/stderr #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
957fcc3
Improve git command error logging to include stdout/stderr
arnavk23 Jan 1, 2026
9d0db83
minor fixes/tweaks
IanButterworth Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tagbot/action/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,16 @@ def command(self, *argv: str, repo: Optional[str] = "") -> str:
proc = subprocess.run(args, text=True, capture_output=True)
out = proc.stdout.strip()
if proc.returncode:
error_msg = f"Git command '{self._sanitize_command(cmd)}' failed"
if out:
logger.info(self._sanitize_command(out))
stdout = self._sanitize_command(out)
logger.error(f"stdout: {stdout}")
error_msg += f"\nstdout: {stdout}"
if proc.stderr:
logger.info(self._sanitize_command(proc.stderr.strip()))
raise Abort(f"Git command '{self._sanitize_command(cmd)}' failed")
stderr = self._sanitize_command(proc.stderr.strip())
logger.error(f"stderr: {stderr}")
error_msg += f"\nstderr: {stderr}"
raise Abort(error_msg)
return out

def check(self, *argv: str, repo: Optional[str] = "") -> bool:
Expand Down
3 changes: 2 additions & 1 deletion test/action/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ def test_command(run):
]
run.assert_has_calls(calls)
run.return_value.configure_mock(stderr="err\n", returncode=1)
with pytest.raises(Abort):
with pytest.raises(Abort) as exc_info:
g.command("d")
assert "stderr: err" in str(exc_info.value)


def test_check():
Expand Down