Merged
Conversation
ranocha
requested review from
ChrisRackauckas,
ViralBShah and
oscardssmith
and removed request for
ChrisRackauckas,
ViralBShah and
oscardssmith
ranocha
force-pushed
the
hr/fix_LV_543
branch
from
ac3344d to
f00dff5
Compare
Member
Author
|
@ChrisRackauckas This is similar to #563 since it discovers some tests that fail on MacOS ARM systems. Can we merge it, too, to keep tracking it in #564? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a fix for #543 in JuliaSIMD/VectorizationBase.jl#125. However, Chris Elrod mentioned that this fix is not really good; instead, the fix should avoid the issue appearing there altogether, likely by fixing an issue inside LoopVectorization.jl. Thus, I added tests for the issue here that pass on Windows/Linux CI and are skipped on Apple ARM systems since they throw a
MethodError.