updating VectorizationBase to support julia 1.12 (continued)#121
updating VectorizationBase to support julia 1.12 (continued)#121ChrisRackauckas merged 10 commits intoJuliaSIMD:masterfrom
Conversation
| fail-fast: false | ||
| matrix: | ||
| julia-version: [1,1.6] | ||
| julia-version: ['lts', '1', 'pre'] |
There was a problem hiding this comment.
| julia-version: ['lts', '1', 'pre'] | |
| julia-version: ['min', 'lts', '1', 'pre'] |
There was a problem hiding this comment.
No, min matches lts so that just adds more CI without being a real change.
There was a problem hiding this comment.
No, it doesn't. They are different releases. min is 1.10.0 whereas lts is the latest 1.10 release (1.10.10 currently I think?).
|
@oscardssmith the spurious doc failures were because that was building with nightly. |
| fail-fast: false | ||
| matrix: | ||
| julia-version: [1,1.6] | ||
| julia-version: ['lts', '1', 'pre'] |
There was a problem hiding this comment.
min is different from lts (see https://github.com/JuliaSIMD/VectorizationBase.jl/pull/121/files#r2280324058):
| julia-version: ['lts', '1', 'pre'] | |
| julia-version: ['min', 'lts', '1', 'pre'] |
There was a problem hiding this comment.
let's take this conversation to a different PR, it at least shouldn't block the fix of pre.
There was a problem hiding this comment.
Good point, I opened a separate PR: #123
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
===========================================
+ Coverage 23.19% 52.25% +29.06%
===========================================
Files 35 35
Lines 5838 6145 +307
===========================================
+ Hits 1354 3211 +1857
+ Misses 4484 2934 -1550 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@oscardssmith are those integration tests all the same failures as master? |
|
yes. I think this is ready to merge. |
Rebased and cleaned up commit history of #119
Part of my submission for the Updating LoopVectorization Project from the SciML small grants program.