Open
Conversation
There is no way to make the `S` keyword argument of `LinearOperator{T}`
inferrable.
This moves `S` to the second position, so anyone who wishes to write
inferrable code can use `LinearOperator{T, Vector{T}}(args...)`.
Author
|
Bump |
Author
|
Any chance someone can take a look at this? Or at least approve the workflow so that the tests can run? (EDIT: now I'm a bit confused about whether this repo actually uses the CI workflow.) |
Author
|
Bump |
Member
|
@timholy I just discovered your PR. |
Member
|
@timholy Can you rebase your branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no way to make the
Skeyword argument ofLinearOperator{T}inferrable.
This moves
Sto the second position, so anyone who wishes to writeinferrable code can use
LinearOperator{T, Vector{T}}(args...).This appears to be non-breaking. A search of the JuliaSmoothOptimizers org for code with
LinearOperator{reveals only one source-code usage with more than one parameter: https://github.com/JuliaSmoothOptimizers/RipQP.jl/blob/6d3c074e72b4e94846a165bed5cc2b78bfdb3623/src/iterations/preconditioners/LDL.jl#L48While the names there will be misleading, there appears to be no functional consequence.