Skip to content

Patch bfgs upper bound #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxenceGollier wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Patch bfgs upper bound #399

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26b3b64
patch bfgs upper bound compute squared norm
MaxenceGollier Feb 4, 2026
c42f951
Merge branch 'JuliaSmoothOptimizers:main' into patch-bfgs-upper-bound
MaxenceGollier Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lbfgs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,10 @@ function push_common!(

# Update arrays a and b used in forward products.
if !op.inverse
data.opnorm_upper_bound -= data.norm_b[insert]
data.opnorm_upper_bound -= data.norm_b[insert]^2
data.b[insert] .= y ./ sqrt(ys)
data.norm_b[insert] = norm(data.b[insert])
data.opnorm_upper_bound += data.norm_b[insert]
data.opnorm_upper_bound += data.norm_b[insert]^2

@inbounds for i = 1:(data.mem)
k = mod(insert + i - 1, data.mem) + 1
Expand Down
Loading