Do not promote mean and covariance of MvNormal to common element type#1965
Do not promote mean and covariance of MvNormal to common element type#1965
MvNormal to common element type#1965Conversation
|
Thanks for giving it a go! How bad is this? I can imagine several of these test failures are fixable. What really matters at the end of the day? That the core API functions are type-stable and respect |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
- Coverage 86.26% 86.24% -0.02%
==========================================
Files 146 146
Lines 8763 8762 -1
==========================================
- Hits 7559 7557 -2
- Misses 1204 1205 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this good to merge, or are there more things to consider? |
|
No, this is a major change, so it requires a bit more discussion, feedback from other maintainers, and should in the end be approved by another maintainer. I'm also not sure yet whether the workaround for |
Ref #1964. Currently just to see if and what it would break.