Update Playwright CDN URL in patch script#96
Open
selimrecep wants to merge 1 commit intoKaliiiiiiiiii-Vinyzu:mainfrom
Open
Update Playwright CDN URL in patch script#96selimrecep wants to merge 1 commit intoKaliiiiiiiiii-Vinyzu:mainfrom
selimrecep wants to merge 1 commit intoKaliiiiiiiiii-Vinyzu:mainfrom
Conversation
3 tasks
Author
|
I've also encountered the same issues (ERR_NAME_NOT_RESOLVED) in CI/CD tests when running them locally with act on my server. I am using Podman instead of Docker, though I doubt that is the cause. The problem might be related to an upstream issue in the patchright repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated CDN URL. Added a validation check for the upstream URL to fail the build immediately if it changes in the future.
Fixes #95, might fix #94