Skip to content

fix: add missing isolated_context params to JSHandle #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StudentWan wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: add missing isolated_context params to JSHandle #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions patch_python_package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ async def route_handler(route: Route) -> None:
async_generated_tree = ast.parse(async_generated_source)

for class_node in ast.walk(async_generated_tree):
if isinstance(class_node, ast.ClassDef) and class_node.name in ["Page", "Frame", "Worker", "Locator"]:
if isinstance(class_node, ast.ClassDef) and class_node.name in ["Page", "Frame", "Worker", "Locator", "JSHandle"]:
for node in class_node.body:
if isinstance(node, ast.AsyncFunctionDef) and (node.name in ["evaluate", "evaluate_handle"] or (class_node.name == "Locator" and node.name == "evaluate_all")): # , "evaluate_all"
new_arg = ast.arg(arg="isolated_context", annotation=ast.Subscript(
Expand Down Expand Up @@ -511,7 +511,7 @@ async def route_handler(route: Route) -> None:
async_generated_tree = ast.parse(async_generated_source)

for class_node in ast.walk(async_generated_tree):
if isinstance(class_node, ast.ClassDef) and class_node.name in ["Page", "Frame", "Worker", "Locator"]:
if isinstance(class_node, ast.ClassDef) and class_node.name in ["Page", "Frame", "Worker", "Locator", "JSHandle"]:
for node in class_node.body:
if isinstance(node, ast.FunctionDef) and (node.name in ["evaluate", "evaluate_handle"] or (class_node.name == "Locator" and node.name == "evaluate_all")): # , "evaluate_all"
new_arg = ast.arg(arg="isolated_context", annotation=ast.Subscript(
Expand Down