Conversation
修复侧边栏退出登录时重复跳转的问题，移除finally中的冗余跳转 为switch组件添加禁用状态支持，包括样式和交互处理 优化插件配置页面的作者信息展示，添加头像回退和边框效果
修复插件详情模态打开时配置详情模态仍显示的问题，通过添加条件判断只在插件详情模态关闭时显示配置详情模态。同时优化移动端布局，包括按钮样式调整和响应式布局改进。
统一使用Button组件替代手动实现的按钮样式，提高代码一致性和可维护性
- 将按钮变体从ghost改为flat - 为按钮添加glass-effect类名
Contributor
|
好的，这是将 pull request review guide 翻译成简体中文的结果： 🧙 Sourcery 已经完成了对您的 pull request 的审查！ 提示和命令与 Sourcery 互动
自定义您的体验访问您的 仪表盘 以：
获取帮助Original review guide in English🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
嘿 @ikenxuan - 我已经查看了你的更改 - 这里有一些反馈：
- 跨组件存在大量重复的 Button props 和 Tailwind classNames——考虑创建一个共享的 Button 包装器或默认 props 来 DRY 这些样式。
- ConfigDetailModal 已经变得相当大，具有单独的移动/桌面页脚——将这些部分提取到更小的子组件中将提高可读性和可维护性。
- 在 createSwitch 中，你正在生成动态的 Tailwind 类，如
text-${props.color}-300，PurgeCSS 可能会将其删除；考虑使用固定的类映射或白名单以避免在生产环境中丢失样式。
以下是我在审查期间查看的内容
- 🟡 一般问题：发现 3 个问题
- 🟢 安全性：一切看起来都很好
- 🟢 测试：一切看起来都很好
- 🟢 复杂性：一切看起来都很好
- 🟢 文档：一切看起来都很好
帮助我变得更有用！请点击每个评论上的 👍 或 👎，我将使用这些反馈来改进你的评论。
Original comment in English
Hey @ikenxuan - I've reviewed your changes - here's some feedback:
- There’s a lot of repeated Button props and Tailwind classNames across components—consider creating a shared Button wrapper or default props to DRY up these styles.
- ConfigDetailModal has grown quite large with separate mobile/desktop footers—extracting those sections into smaller subcomponents would improve readability and maintainability.
- In createSwitch you’re generating dynamic Tailwind classes like
text-${props.color}-300, which PurgeCSS may strip out; consider using a fixed class map or whitelisting to avoid missing styles in production.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| hideCloseButton={false} | ||
| isDismissable | ||
| isKeyboardDismissDisabled={false} | ||
| portalContainer={document.body} |
Contributor
There was a problem hiding this comment.
问题 (bug_risk): 直接使用 document.body 可能会破坏 SSR
将 portalContainer 的设置推迟到仅客户端生效，或使用 typeof window !== 'undefined' 进行保护，以避免 SSR 错误。
Original comment in English
issue (bug_risk): Using document.body directly may break SSR
Defer setting portalContainer to a client-only effect or guard with typeof window !== 'undefined' to avoid SSR errors.
|
|
||
| const handleContainerClick = (e: React.MouseEvent) => { | ||
| // 如果组件被禁用，不触发开关切换 | ||
| if (isDisabled) return |
Contributor
There was a problem hiding this comment.
建议: 添加 aria-disabled 以增强可访问性
在根元素上添加 aria-disabled 将增强屏幕阅读器用户在开关禁用时的可访问性。
Original comment in English
suggestion: Add aria-disabled for accessibility
Adding aria-disabled to the root element will enhance accessibility for screen reader users when the switch is disabled.
|
|
||
| return ( | ||
| <div className='space-y-4'> | ||
| <Card className='p-4 lg:p-6 sticky top-0 md:top-[23px] lg:top-[23px] z-10 bg-opacity-5 justify-center gap-2 backdrop-blur-xl bg-gradient-to-br from-white/20 via-white/10 to-white/5 dark:from-white/15 dark:via-white/8 dark:to-white/3 border-t border-lborder-r border-b border-white/10 dark:border-white/5 shadow-2xl transition-all duration-500 overflow-hidden before:absolute before:inset-0 before:bg-gradient-to-br before:from-white/10 before:via-transparent before:to-transparent before:opacity-0 before:transition-opacity before:duration-300'> |
Contributor
There was a problem hiding this comment.
问题 (typo): Tailwind 边框类中的错别字
border-l 和 border-r 之间缺少空格，因此该类未正确应用。请更新为 border-l border-r。
Suggested change
| <Card className='p-4 lg:p-6 sticky top-0 md:top-[23px] lg:top-[23px] z-10 bg-opacity-5 justify-center gap-2 backdrop-blur-xl bg-gradient-to-br from-white/20 via-white/10 to-white/5 dark:from-white/15 dark:via-white/8 dark:to-white/3 border-t border-lborder-r border-b border-white/10 dark:border-white/5 shadow-2xl transition-all duration-500 overflow-hidden before:absolute before:inset-0 before:bg-gradient-to-br before:from-white/10 before:via-transparent before:to-transparent before:opacity-0 before:transition-opacity before:duration-300'> | |
| <Card className='p-4 lg:p-6 sticky top-0 md:top-[23px] lg:top-[23px] z-50 bg-opacity-5 justify-center gap-2 backdrop-blur-xl bg-gradient-to-br from-white/20 via-white/10 to-white/5 dark:from-white/15 dark:via-white/8 dark:to-white/3 border-t border-l border-r border-b border-white/10 dark:border-white/5 shadow-2xl transition-all duration-500 overflow-hidden before:absolute before:inset-0 before:bg-gradient-to-br before:from-white/10 before:via-transparent before:to-transparent before:opacity-0 before:transition-opacity before:duration-300'> |
Original comment in English
issue (typo): Typo in Tailwind border classes
There's a missing space between border-l and border-r, so the class isn't applied correctly. Please update to border-l border-r.
Suggested change
| <Card className='p-4 lg:p-6 sticky top-0 md:top-[23px] lg:top-[23px] z-10 bg-opacity-5 justify-center gap-2 backdrop-blur-xl bg-gradient-to-br from-white/20 via-white/10 to-white/5 dark:from-white/15 dark:via-white/8 dark:to-white/3 border-t border-lborder-r border-b border-white/10 dark:border-white/5 shadow-2xl transition-all duration-500 overflow-hidden before:absolute before:inset-0 before:bg-gradient-to-br before:from-white/10 before:via-transparent before:to-transparent before:opacity-0 before:transition-opacity before:duration-300'> | |
| <Card className='p-4 lg:p-6 sticky top-0 md:top-[23px] lg:top-[23px] z-50 bg-opacity-5 justify-center gap-2 backdrop-blur-xl bg-gradient-to-br from-white/20 via-white/10 to-white/5 dark:from-white/15 dark:via-white/8 dark:to-white/3 border-t border-l border-r border-b border-white/10 dark:border-white/5 shadow-2xl transition-all duration-500 overflow-hidden before:absolute before:inset-0 before:bg-gradient-to-br before:from-white/10 before:via-transparent before:to-transparent before:opacity-0 before:transition-opacity before:duration-300'> |
- 将火箭图标替换为向上箭头并添加进度环显示滚动百分比 - 实现滚动时显示百分比，停止滚动后显示箭头的动画效果 - 添加Tooltip提示并改进按钮的视觉效果和交互 - 优化边缘检测和拖拽逻辑，提升用户体验
...渲染压力好大
在描述文本的className中添加break-all以允许在任何字符处换行，避免长文本溢出
Contributor
|
你可以通过以下命令安装该版本： |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.