Skip to content

fix: 修改插件名为plugin-puppeteer#578

Merged
sj817 merged 1 commit intomainfrom
ys-dev
Dec 12, 2025
Merged

fix: 修改插件名为plugin-puppeteer#578
sj817 merged 1 commit intomainfrom
ys-dev

Conversation

@yusheng929
Copy link
Contributor

@yusheng929 yusheng929 commented Dec 8, 2025

Summary by Sourcery

错误修复:

  • 更正 renderer-empty 错误消息中提到的插件名称,使其指向 @karinjs/plugin-puppeteer
Original summary in English

Summary by Sourcery

Bug Fixes:

  • Correct the plugin name mentioned in the renderer-empty error message to point to @karinjs/plugin-puppeteer.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected cache error message to reference the accurate package name suggestion for improved user guidance.

✏️ Tip: You can customize this high-level summary in your review settings.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yusheng929, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在修复一个错误消息,通过将其中引用的插件名称从 puppeteer 更新为 plugin-puppeteer。这确保了当渲染器列表为空时,用户会收到正确的插件安装指示,从而提高了用户体验和系统准确性。

Highlights

  • 插件名称更新: 在错误消息中,将插件名称从 @karinjs/puppeteer 更新为 @karinjs/plugin-puppeteer,以确保用户被引导到正确的插件名称。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025

Walkthrough

An error message in the render admin cache module was updated to reflect the correct package name from @karinjs/puppeteer to @karinjs/plugin-puppeteer for improved user guidance when the cache is empty.

Changes

Cohort / File(s) Summary
Error message correction
packages/core/src/adapter/render/admin/cache.ts
Updated plugin name reference in error message from @karinjs/puppeteer to @karinjs/plugin-puppeteer

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny fix, but oh so clear,
The package name now points us here,
From puppeteer to plugin-puppeteer's call,
A rabbit's touch corrects it all! 🎯

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: updating the plugin name from @karinjs/puppeteer to @karinjs/plugin-puppeteer in an error message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ys-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 8, 2025

评审者指南(在小型 PR 上折叠)

评审者指南

更新管理员渲染适配器在缓存为空时的错误信息,使其引用重命名后的 puppeteer 插件包 '@karinjs/plugin-puppeteer',而不是旧的包名。

按文件划分的变更

变更 详情 文件
当没有注册任何渲染器时,更新错误消息以引用新的 puppeteer 插件包名称。
  • 当渲染缓存为空时,将抛出 Error 中的插件安装提示从 '@karinjs/puppeteer' 修改为 '@karinjs/plugin-puppeteer'
  • 保持渲染获取逻辑(随机选择或按 id)不变
packages/core/src/adapter/render/admin/cache.ts

提示与命令

与 Sourcery 交互

  • 触发新的代码评审: 在 pull request 上评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的评审评论。
  • 从评审评论生成 GitHub issue: 通过回复某条评审评论,请求 Sourcery 从该评论创建一个 issue。你也可以直接回复该评论 @sourcery-ai issue 来创建对应的 issue。
  • 生成 pull request 标题: 在 pull request 标题的任意位置写上 @sourcery-ai,即可随时生成一个标题。你也可以在 pull request 上评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 总结: 在 pull request 描述正文的任意位置写上 @sourcery-ai summary,即可在你指定的位置生成 PR 总结。你也可以在 pull request 上评论 @sourcery-ai summary 来(重新)生成总结。
  • 生成评审者指南: 在 pull request 上评论 @sourcery-ai guide,即可随时(重新)生成评审者指南。
  • 解决所有 Sourcery 评论: 在 pull request 上评论 @sourcery-ai resolve,即可将所有 Sourcery 评论标记为已解决。如果你已经处理了所有评论且不再希望看到它们,这会很有用。
  • 忽略所有 Sourcery 评审: 在 pull request 上评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 评审。尤其适用于你想从头开始一次新的评审时 —— 别忘了再评论 @sourcery-ai review 来触发新一轮评审!

自定义你的体验

访问你的控制面板以:

  • 启用或禁用诸如 Sourcery 自动生成的 pull request 总结、评审者指南等评审功能。
  • 更改评审语言。
  • 添加、移除或编辑自定义评审指令。
  • 调整其他评审相关设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the admin render adapter’s empty-cache error message to reference the renamed puppeteer plugin package '@karinjs/plugin-puppeteer' instead of the old name.

File-Level Changes

Change Details Files
Update error message to reference the new puppeteer plugin package name when no renderers are registered.
  • Change the plugin installation hint in the thrown Error from '@karinjs/puppeteer' to '@karinjs/plugin-puppeteer' when the render cache is empty
  • Keep render retrieval logic (random selection or by id) unchanged
packages/core/src/adapter/render/admin/cache.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗨,我已经审查了你的更改,看起来非常棒!


Sourcery 对开源项目是免费的——如果你觉得我们的代码审查有帮助,欢迎分享给更多人 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进后续的审查。
Original comment in English

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 修复了错误信息中不正确的插件名称,将 @karinjs/puppeteer 修改为 @karinjs/plugin-puppeteer。这是一个正确的修复。为了提高代码的可维护性,我建议将插件名称提取为常量,以避免在代码中硬编码字符串。

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

你可以通过以下命令安装该版本:

pnpm add https://pkg.pr.new/KarinJS/Karin/node-karin@f8c11ca -w

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ac356e and f8c11ca.

📒 Files selected for processing (1)
  • packages/core/src/adapter/render/admin/cache.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Sourcery review
  • GitHub Check: publish-temp

@sj817 sj817 merged commit 5f48dba into main Dec 12, 2025
5 checks passed
@sj817 sj817 deleted the ys-dev branch December 12, 2025 02:16
@github-actions github-actions bot mentioned this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants