NEON: replace numeric conversion with bit reinterpretation in SIMD log#70
Merged
zkingston merged 1 commit intoKavrakiLab:mainfrom Sep 22, 2025
Merged
NEON: replace numeric conversion with bit reinterpretation in SIMD log#70zkingston merged 1 commit intoKavrakiLab:mainfrom
zkingston merged 1 commit intoKavrakiLab:mainfrom
Conversation
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neon SIMD
logwas clamping via integer->float conversion instead of a bit reinterpretation ofFLT_MIN, and exponent masking wasn’t purely bitwise. This PR switches to a bit cast and explicit bit masking.I noticed this while testing AORRTC: it causes
ProlateHyperspheroidRNGin AORRTC to produce NaNs, so informed sampling didn’t work as intended. The issue only affects ARM/NEON builds.