You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently this middleware supporting only flysystem v1 was released 8 years ago(19th of January in 2015). This PR added support for newer version flysystem v3
The CI fail because we support PHP 7. league/flysystem[3.16.0, ..., 3.17.0] require php ^8.0.2 -> your php version (7.2.34) does not satisfy that requirement.
But PHP 7 is end-of-life. So maybe we can drop it? What do you think?
I think dropping support for PHP 7 would be a breaking change to this plugin. Flysystem v2 supports PHP 7.2. If you agree, I can create a separate PR to release a new version with Flysystem v2. Then we can release another version with PHP 8 and Flysystem v3.
I think dropping support for PHP 7 would be a breaking change to this plugin. Flysystem v2 supports PHP 7.2. If you agree, I can create a separate PR to release a new version with Flysystem v2. Then we can release another version with PHP 8 and Flysystem v3.
The support of PHP <8 is now dropped on the master branch. @marufmax Can you update your PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently this middleware supporting only flysystem v1 was released 8 years ago(19th of January in 2015). This PR added support for newer version flysystem v3