fix: add omitempty support for list types with pointer_omitempty#413
Open
fix: add omitempty support for list types with pointer_omitempty#413
Conversation
added 2 commits
January 29, 2026 10:17
When using use_struct_references: true with optional: pointer_omitempty, list types like [String!] were not getting the omitempty tag because the convertType function returned early for slice types, skipping the pointer_omitempty handling logic. This fix ensures that list types also respect the pointer_omitempty configuration when the list itself is nullable.
gofulljs
requested review from
StevenACoffman,
benjaminjkraft,
csilvers and
dnerdy
as code owners
benjaminjkraft
approved these changes
Jan 29, 2026
Collaborator
benjaminjkraft
left a comment
benjaminjkraft
left a comment
There was a problem hiding this comment.
seems like a bug to me, thanks for the fix!
Collaborator
|
I think the test failure is still a flake, but it looks like we don't have a CLA from you, could you fill that out? |
Author
|
I’ve signed the CLA, thanks. |
added 3 commits
February 2, 2026 10:03
When using use_struct_references: true with optional: pointer_omitempty, list types like [String!] were not getting the omitempty tag because the convertType function returned early for slice types, skipping the pointer_omitempty handling logic. This fix ensures that list types also respect the pointer_omitempty configuration when the list itself is nullable.
…ulljs/genqlient into fix-pointer-omitempty-for-list-types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed
pointer_omitemptynot being applied to list types whenuse_struct_referencesis enabled. List fields like[String!]now correctly get theomitemptyJSON tag