Fix naming inconsistency khr

[Bogumil-Sapinski-Mobica]

No description provided.

[bashbaug]

Thanks, this looks like the right direction, but the inconsistency still exists because now the CommandBuffer and MutableCommandBuffer classes are in the khr namespace, but the Semaphore class is not. Are you planning to move the Semaphore class into the khr namespace also?

As an aside, it looks like parts of this file were reformatted but had no other changes. I would generally advise against this, but if would like to reformat parts of the file could you please do it as the first or last commit? This will make it easier to see and review the non-formatting changes - thanks!

[Bogumil-Sapinski-Mobica]

Hi @bashbaug
sorry for mixing formatting changes with task related changes.
Would you like me to create new PR with these changes or should I continue with Semaphore?

[bashbaug]

Related to #233

[bashbaug]

Thanks, this mostly looks good to me, thanks for making these changes.

I have one specific comment for the test changes, see below.

Additionally, I'd like to reiterate that formatting related changes make it much harder to review this PR than it should be. I'd strongly recommend reverting the formatting changes to minimize diffs.

Finally it appears that this PR needs a rebase since there are merge conflicts.

[bashbaug]

This is a little ugly. How about this as an alternative:

1. Separate out the "type" and the "typestr", whereas we just have a single "type" currently.
2. Use Context as the "typestr" in this case, and e.g. CommandBuffer as the "typestr" in the command buffer cases.
3. Use cl::Context as the "type" in this case, and e.g. cl::khr::CommandBuffer as the "type" in the command buffer cases.

I think this will require fewer diffs, and it won't require putting the tests themselves inside of the cl or cl::khr namespaces, which they really shouldn't be doing.

[kamil-goras-mobica]

@bashbaug In last commit (73c5491 73c5491) I have added corrections and removed not needed style corrections.

[CLAassistant]

All committers have signed the CLA.

[bashbaug]

Apologies for the long review delay. The updated change LGTM. There needs to be a rebase (in the test code?) now, but hopefully that is straightforward.

Noting for completeness: these changes do break backward compatibility so they will require code changes for applications using the C++ bindings with semaphores and command buffers.