UT for createSubBuffer

[piotr-wozniak-mobica]

No description provided.

[bashbaug]

Please make this variable non-static:

Suggested change

	static cl::Buffer ret;
	clCreateSubBuffer_StubWithCallback(clCreateSubBuffer_testCreateSubBuffer);
	ret = bufferPool[0].createSubBuffer(flags, buffer_create_type,
	buffer_create_info, err);
	TEST_ASSERT_EQUAL_PTR(make_mem(1), ret());
	ret() = nullptr;
	clCreateSubBuffer_StubWithCallback(clCreateSubBuffer_testCreateSubBuffer);
	clReleaseMemObject_ExpectAndReturn(make_mem(1), CL_SUCCESS);
	cl::Buffer ret = bufferPool[0].createSubBuffer(flags, buffer_create_type,
	buffer_create_info, err);
	TEST_ASSERT_EQUAL_PTR(make_mem(1), ret());

[bashbaug]

We really ought to be testing more real-world values here:

• buffer - this one is OK.
• flags - a value of 0 is legal, but it's not a very useful value to test to see if the flags are being passed through properly. Maybe pass something like CL_MEM_READ_ONLY instead?
• buffer_create_type - this should be CL_BUFFER_CREATE_TYPE_REGION, since this is the only buffer creation type described in the spec.
• buffer_create_info - this should be a non-NULL pointer to a cl_buffer_region structure. Ideally, we should check that the pointer is non-NULL, and that the contents of the structure are what we expect.

[kamil-goras-mobica]

@bashbaug Added corrections.