UT for enqueueMarkerWithWaitList#257
Open
piotr-wozniak-mobica wants to merge 3 commits intoKhronosGroup:mainfrom
Open
UT for enqueueMarkerWithWaitList#257piotr-wozniak-mobica wants to merge 3 commits intoKhronosGroup:mainfrom
piotr-wozniak-mobica wants to merge 3 commits intoKhronosGroup:mainfrom
Conversation
bashbaug
requested changes
Nov 15, 2023
tests/test_openclhpp.cpp
Outdated
Comment on lines
4536
to
4537
| cl::Event event; | ||
| cl::vector<cl::Event> events = {event}; |
Contributor
There was a problem hiding this comment.
This is not valid "real-world" code - the set of events in the event wait list must be different than the event that is signaled. Coudl you please make a specific event to wait upon instead? This would also allow us to ensure that it was passed through correctly.
Something like:
Suggested change
| cl::Event event; | |
| cl::vector<cl::Event> events = {event}; | |
| cl::Event event; | |
| cl::vector<cl::Event> events = {cl::Event(make_event(0))}; |
Contributor
|
@bashbaug correction added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.