Don't link directly to clFinalizeCommandBufferKHR#320
Merged
bashbaug merged 1 commit intoKhronosGroup:mainfrom Dec 18, 2024
Merged
Don't link directly to clFinalizeCommandBufferKHR#320bashbaug merged 1 commit intoKhronosGroup:mainfrom
bashbaug merged 1 commit intoKhronosGroup:mainfrom
Conversation
It's an extension function so use the runtime function pointer like for the other command buffer functions.
|
|
bashbaug
approved these changes
Dec 18, 2024
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
I was wondering how we were passing the unit tests with this bug, but it looks like we don't have any tests that finalize a command buffer yet (we do have PR #270, but I'm not sure it would have caught this problem, either). We should add some tests to catch these types of problems.... but not in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's an extension function so use the runtime function pointer like for the other command buffer functions.
Fixes #292