spirv-val: Add SPV_KHR_ray_tracing_position_fetch#6539
Open
spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Open
spirv-val: Add SPV_KHR_ray_tracing_position_fetch#6539spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
spencer-lunarg
commented
Feb 7, 2026
| namespace spvtools { | ||
| namespace val { | ||
|
|
||
| spv_result_t RayTracingPass(ValidationState_t& _, const Instruction* inst) { |
Contributor
Author
There was a problem hiding this comment.
I ended up not adding anything to here, but had it "cleaned up" to matched the other pass files
alan-baker
requested changes
Feb 7, 2026
| !_.IsFloatVectorType(_.GetComponentType(result_type)) || | ||
| _.GetDimension(_.GetComponentType(result_type)) != 3) { | ||
| return _.diag(SPV_ERROR_INVALID_DATA, inst) | ||
| << "Expected 3 element array of 32-bit 3 component float point " |
Contributor
There was a problem hiding this comment.
The 32-bit aspect doesn't actually appear to be checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5884