Split up the big main test into many smaller ones#1304
Open
adamchalmers wants to merge 7 commits intomainfrom
Open
Split up the big main test into many smaller ones#1304adamchalmers wants to merge 7 commits intomainfrom
adamchalmers wants to merge 7 commits intomainfrom
Conversation
1157a19 to
90fe3d0
Compare
2ce47c5 to
528f4d4
Compare
| name: "version".to_string(), | ||
| args: vec!["zoo".to_string(), "version".to_string()], | ||
| want_out: format!( | ||
| "zoo {} )({})\n{}", |
Contributor
There was a problem hiding this comment.
There's a syntax error in the format string. The parentheses are incorrectly ordered - it currently reads zoo {} )({})\n{} but should be zoo {} ({})\n{}. This will cause a runtime error when formatting the version string.
Suggested change
| "zoo {} )({})\n{}", | |
| "zoo {} ({})\n{}", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
cf2c70b to
76a3f05
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR currently has a problem with logging in.
Many of the tests require a logged-in Zoo CLI. That's fine in the current model, where all tests run in one process sequentially. But with nextest, each test runs in its own process. So each test has to log in, then run its test. That was fine but somehow, each test would successfully run its login code, and then try to run the relevant test (e.g.
zoo kcl mass). But that relevant test would fail, saying you weren't logged in. Seems like the test wasn't passing the logged-in status into the next CLI invocation. Idk what to do about it.