Skip to content

ZDS support for Back‑face color setting#9828

Draft
pierremtb wants to merge 5 commits intomainfrom
pierremtb/issue9096-ZDS-support-for-Back‑face-color-setting

Hidden character warning

The head ref may contain hidden characters: "pierremtb/issue9096-ZDS-support-for-Back\u2011face-color-setting"
Draft

ZDS support for Back‑face color setting#9828
pierremtb wants to merge 5 commits intomainfrom
pierremtb/issue9096-ZDS-support-for-Back‑face-color-setting

Conversation

@pierremtb
Copy link
Contributor

@pierremtb pierremtb commented Jan 26, 2026

Fixes #9096

TODO:

  • Figure out how to send the new setting on change without a full reload, likely through the same mechanism as Add color opacity #9506
  • See the tests we'd need for this

@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
modeling-app Ready Ready Preview, Comment Jan 26, 2026 10:09pm

Request Review

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 26, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 10.76%

Comparing pierremtb/issue9096-ZDS-support-for-Back‑face-color-setting (decc091) with main (6ca538d)1

Summary

❌ 1 regressed benchmark
✅ 152 untouched benchmarks
⏩ 93 skipped benchmarks2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation mock_execute_mike_stress_test_program 343.2 ms 384.6 ms -10.76%

Footnotes

  1. No successful run was found on main (c3ed921) during the generation of this report, so 6ca538d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 93 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZDS support for Back‑face color setting

1 participant