bug: retry 3 attempts automatically each time you see a 1006 error code#9870
Open
bug: retry 3 attempts automatically each time you see a 1006 error code#9870
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…deling-app into nadro/gh-9869/websocket-1006
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9869
Issue
When the user is using the engine they could be randomly disconnected when the websocket closes with the event code
1006. A user can get this if the pod they are connected to is redeploying (they get booted), the engine crashes, the engine goes OOM (out of mana).In the case of the engine redeploying and closing we would want to automatically reconnect them since they are not going to be in an infinite boot loop.
Gotcha: If a user produces a KCL file that crashes the engine and we see 1006, we do not want to always reconnect them automatically forever they would be in a loop that would connect, render, crash from rendering, reconnect etc.. forever in a loop.
After 3 retries on 1006 error we show the manual reconnection modal for them to press manually.
Implementation
Documentation
https://datatracker.ietf.org/doc/html/rfc6455#section-7.4.1
1006