Add auto-save option #1580
Open
Add auto-save option #1580
+125
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new setting to automatically save annotation changes after a 2-second debounce delay. The feature batches rapid edits to reduce server requests and respects readonly mode. Disabled by default for backward compatibility. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add auto-save toggle to desktop Settings view under Annotation Settings - Add Annotation Settings section to web-girder Settings view with multi-camera toolbar and auto-save toggles - Change save icon to show gear (mdi-content-save-cog) when auto-save is enabled to visually indicate automated saving is active Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The save() function was unconditionally exiting editing mode before saving, which caused issues when auto-save was enabled: users would be kicked out of polygon/segmentation editing mode after 2 seconds when auto-save triggered. Added an optional exitEditingMode parameter (defaults to false) so auto-save no longer disrupts the user's editing session. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
naglepuff
requested changes
Jan 28, 2026
Collaborator
naglepuff
left a comment
naglepuff
left a comment
There was a problem hiding this comment.
Couple of small bits of feedback, but mostly looks good
Comment on lines
+22
to
+33
| <v-row> | ||
| <v-col> | ||
| <v-switch | ||
| v-model="clientSettings.multiCamSettings.showToolbar" | ||
| color="primary" | ||
| label="Show multi-camera toolbar" | ||
| hint="Show multi-camera editing tools in the top toolbar when a track is selected" | ||
| persistent-hint | ||
| class="my-0" | ||
| /> | ||
| </v-col> | ||
| </v-row> |
Collaborator
There was a problem hiding this comment.
Since this isn't related to auto-save, and we don't yet support stereo/multi camera in web, should we remove this for now?
| async () => { | ||
| if (readonlyState.value) return; | ||
| if (pendingSaveCount.value === 0) return; | ||
| if (saveInProgress.value) return; |
Collaborator
There was a problem hiding this comment.
What happens if a user makes a change while a save is happening? I assume that this debounced function will be scheduled, but may end up returning early if a previous save is still in progress.
Should we also be watching saveInProgress, and check to see if we need to retry the save after the value changes from true to false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Body:
Summary
mdi-content-save-cog) when auto-save is enabled to visually indicate automated saving is activeTest plan
The branch contains 2 commits: