Fix computation of interaction transform used in PositionProp#141
Open
jcfr wants to merge 1 commit intoKitwareMedical:masterfrom
Open
Fix computation of interaction transform used in PositionProp#141jcfr wants to merge 1 commit intoKitwareMedical:masterfrom
jcfr wants to merge 1 commit intoKitwareMedical:masterfrom
Conversation
…ionProp This commit adds detailed comments documenting each step involved in computing the interaction transform used in the PositionProp. The corresponding code was initially introduced in commit 503ef1d ("ENH: Add VR interactor style class for transforming objects in MRML", 2018-08-31). Co-authored-by: David Allemang <david.allemang@kitware.com>
jcfr
changed the title
Contributor
Author
|
Since the previous attempt at addressing the issue was incorrect1, another approach suggested by @LucasGandel would be to review the implementation of similar computation used in Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds detailed comments documenting each step involved in computing the interaction transform used in the PositionProp. The corresponding code was initially introduced in commit 503ef1d ("ENH: Add VR interactor style class for transforming objects in MRML", 2018-08-31).