feat(gmail): improve error logging for pre-tool-calling checks #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract type definitions (GmailMessagePart, EmailAttachment, EmailContent) and Zod schemas (SendEmailSchema, ReadEmailSchema, etc.) into a dedicated module for better code organization and maintainability.
Consolidate utility functions into a dedicated module: - Email utilities (createEmailMessage, validateEmail, encodeEmailHeader) - PDF extraction using pdfjs-dist (Mozilla PDF.js) for better compatibility - DOCX extraction using mammoth - XLSX extraction using exceljs - Base64 conversion utilities - Email content extraction from MIME parts - Batch processing utilities with fallback handling - Contact search warmup functionality
- Update imports to use schemas.js and utils.js - Remove inline type definitions (moved to schemas.ts) - Remove inline utility functions (moved to utils.ts) - Remove inline Zod schemas (moved to schemas.ts) - Add express.json() middleware for proper request body parsing - Add await to asyncLocalStorage.run() for proper async handling
All functionality has been migrated to utils.ts with the proper naming convention. The utl.ts file is no longer needed.
Add a table listing all available MCP tools with their names and descriptions for easier reference.
Add GmailErrorType enum, GmailMCPError class, error parsing functions (parseGoogleApiError, parseZodError), error formatting with guidance, and input validation helpers (validateEmailAddresses, validateId, validateIds, validateApiResponse, sanitizeEmailContent).
Add input validation to handleEmailAction (email addresses, thread ID), replace generic catch block with structured error classification (GmailMCPError / ZodError / Google API error), and log typed error details to console.
Jayyk09
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request extends the Gmail MCP server refactoring by adding structured error handling, input validation utilities, and documentation improvements.
This expands on PR #958 to improve upon error handling and explicit checks for ids, permissions and email addresses before tools are called. Uses basic regex pattern search and adds actionable items based on Error Status for users.
Should only be merged after PR 958
Key Changes
Code Organization:
Error Handling (utils.ts):
Validation (utils.ts):
Related issue
Type of change
How has this been tested?
Checklist