Fix CORS middleware to handle Authorization header #3133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Authorizationheaders in addition to cookies when determining whether to return specific origin vs wildcardBackground
When sending a CORS request with credentials (either cookies or Authorization header), the wildcard origin (
*) is rejected by the browser according to the CORS specification. The middleware was correctly handling this for cookies, but not for Authorization headers.Since token-based authentication (Bearer tokens) is widely used in modern APIs, the Authorization header should be treated the same as cookies when determining CORS behavior.
Changes
authorizationheader alongside the existing cookie check instarlette/middleware/cors.pyTesting
All existing tests pass, and new tests verify the Authorization header behavior:
CORS Specification Compliance
According to the CORS spec, when credentials are present in a request, the
Access-Control-Allow-Originresponse header cannot be*and must specify the exact origin. This applies to both:Fixes #1832