Skip to content

CI: fix kcfg sync workflow#1255

Merged
tao12345666333 merged 3 commits intomainfrom
fix-kcfg-sync-ci
Mar 18, 2025
Merged

CI: fix kcfg sync workflow#1255
tao12345666333 merged 3 commits intomainfrom
fix-kcfg-sync-ci

Conversation

@tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Feb 26, 2025

What this PR does / why we need it:

This pull request includes updates to the GitHub Actions workflow for syncing Kubernetes configuration CRDs. The changes focus on updating permissions, switching the shell used for a script, and modifying the process for committing changes to a new branch.

Workflow updates:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@tao12345666333 tao12345666333 requested a review from a team as a code owner February 26, 2025 13:29
@tao12345666333 tao12345666333 self-assigned this Feb 26, 2025
@tao12345666333
Copy link
Member Author

Since our current security policy does not allow creating PRs via GitHub actions, I will modify its goal to only prepare branches via CI and then create PRs manually.

@tao12345666333
Copy link
Member Author

An example of a successful GitHub action that I ran using this configuration

https://github.com/Kong/charts/actions/runs/13559914224/job/37901027452

It created such a commit

3981515

@tao12345666333 tao12345666333 enabled auto-merge (squash) February 27, 2025 06:31
@pmalek
Copy link
Member

pmalek commented Feb 27, 2025

Since our current security policy does not allow creating PRs via GitHub actions, I will modify its goal to only prepare branches via CI and then create PRs manually.

AFAIK this limitation is only for GITHUB_TOKEN, right? If we'd use a custom PAT then we could create the PRs (given that the permission for this would be assigned to the PAT). WDYT?

@tao12345666333
Copy link
Member Author

Yes.

However, there is no bot token set in this repository. Maybe we can set some secrets like in kic repo.

@tao12345666333 tao12345666333 force-pushed the fix-kcfg-sync-ci branch 3 times, most recently from af02ce3 to 4ab0536 Compare February 27, 2025 13:10
@tao12345666333
Copy link
Member Author

The workflow has been fixed through this PR, and it has run successfully.
https://github.com/Kong/charts/actions/runs/13567191027

It created a PR.
#1259

@tao12345666333
Copy link
Member Author

Using the latest update, it has run successfully and created this PR.

@tao12345666333 tao12345666333 requested a review from czeslavo March 4, 2025 13:09
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor nits, otherwise LGTM.

Please also resolve the conflicts.

Disables draft mode for PR to allow automatic merges
Adds labels for easier tracking of dependencies updates
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Member Author

Created #1276

@tao12345666333 tao12345666333 requested a review from pmalek March 18, 2025 14:35
pmalek
pmalek previously approved these changes Mar 18, 2025
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 merged commit e6d3a06 into main Mar 18, 2025
39 checks passed
@tao12345666333 tao12345666333 deleted the fix-kcfg-sync-ci branch March 18, 2025 15:42
@pmalek
Copy link
Member

pmalek commented Mar 18, 2025

I believe this PR missed setting the .version and .appVersion in the chart. #1278 attempts to do just that.

@tao12345666333 PTAL

@tao12345666333
Copy link
Member Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants