Skip to content

Conversation

@neomaxwell
Copy link
Contributor

@neomaxwell neomaxwell commented Jun 9, 2025

fix: enable vite plugin config override FontSplitProps

Summary by Sourcery

Bug Fixes:

  • Enable config override of FontSplitProps by moving ...this.config to the end of the fontSplit options

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 9, 2025

Reviewer's Guide

This PR modifies how the plugin’s configuration is applied to the fontSplit call by repositioning the spread of this.config to occur after default parameters, allowing user-provided config values to override built-in defaults.

Sequence Diagram: Configuration Override Logic for fontSplit Call

sequenceDiagram
    participant PluginMethod as "BundlePlugin Method"
    participant FontSplit as "fontSplit()"

    alt "Before PR: User config (this.config) spread first, potentially overridden by explicit parameters"
        PluginMethod->>FontSplit: fontSplit({ ...this.config, explicitParam1, explicitParam2, ... })
    else "After PR: Explicit parameters first, user config (this.config) spread last, ensuring override"
        PluginMethod->>FontSplit: fontSplit({ explicitParam1, explicitParam2, ..., ...this.config })
    end
Loading

File-Level Changes

Change Details Files
Reposition plugin config spread to allow overrides
  • Removed initial spread of this.config before default args
  • Added spread of this.config after setting silent flag
packages/vite/src/subset/index.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wangyzhao - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants