Missing 3D assets for completing the Francos Island library + Twinkling star shader extraction#696
Merged
agrande merged 10 commits intoLBALab:masterfrom Jun 7, 2025
Merged
Conversation
Layout 070.
Layout 071.
Layouts 000, 001, 010, 011.
Layouts 009 and 012. Added custom keepMat materials to these and the padded armchair.
Layouts 022 and 025
Moved brick in Franco's Island's bar.
Layout 080.
Layout 073.
New Layout added: Layout 083. Fixed a positioning issue with Layout 073.
SendellX
requested review from
agrande,
fraserjgordon,
slwilliams and
xesf
as code owners
❌ Deploy Preview for lbaremake failed.
|
Member
|
Awesome stuff!!! |
Attempt to extract and adapt the twinkling star shader from the Dome level. Added two of those around Mr. Kurtz's golden globe in scene 173 (entry 117). Fix: Reversed vertex index order so the front side of the triangles would be drawn facing the camera. That way, the star doesn't need to be double sided ✌️
Member
Author
Thanks 💙 I hope it's been a good long time at least 😊 I made some small changes suggested by agrande so it seems the code wasn't too bad 🥳 |
agrande
approved these changes
Jun 7, 2025
Member
|
Hmm, looks like the netlify deployment failed. Some issue with a missing config file. |
Member
|
Not that I remember. There were a few bug fixes releases that worked well. I wonder their service change and we need to upgrade something. I can have a look at that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HAPPY B-DAY TO OUR LOVELY REMAKE PROJECT! 🥳
As a little celebration, I tried to extract the star shader from the Dome level through AI-assisted ✨vibe coding✨ I did my best to understand how it works, but I'm obviously still not a programmer, so I'm counting on your expertise to check if it makes any sense or if there's a better way to approach it!
If it's total nonsense, feel free to discard it entirely – I’ll just commit the 3D models instead 🤣
Speaking of which, this PR also includes all the missing models needed to complete the Francos Island asset replacement, yay! 🎉
Here's the screenshot of the very clean globe I added the stars to 🤭
